Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improving if to match also schedule and workflow_dispatch #3223

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 27, 2024

Description

The unit tests are not running currently because of the last reorg of the workflow steps done in #3171, because now they depends on the smoke tests which were not running previously on schedule or workflow dispatch.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner June 27, 2024 12:51
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.02%. Comparing base (7c1eb1e) to head (091e807).
Report is 28 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (7c1eb1e) and HEAD (091e807). Click for more details.

HEAD has 267 uploads less than BASE
Flag BASE (7c1eb1e) HEAD (091e807)
v23.2-ubuntu 12 0
minimal 20 2
ubuntu 40 2
local 40 2
v24.1-ubuntu-student 12 1
latest-ubuntu-student 12 1
latest-ubuntu 12 0
v24.1-ubuntu 11 0
centos 45 0
remote 45 0
v23.1-ubuntu 4 0
v22.2.1 4 0
v22.2-ubuntu 3 0
v23.2.0 4 0
v24.2.0 4 0
v24.1.0 4 0
v23.1.0 3 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3223       +/-   ##
===========================================
- Coverage   86.63%   63.02%   -23.62%     
===========================================
  Files          52       53        +1     
  Lines        9550     9625       +75     
===========================================
- Hits         8274     6066     -2208     
- Misses       1276     3559     +2283     

@germa89
Copy link
Collaborator Author

germa89 commented Jun 27, 2024

Tested on workflow-dispatch on here: https://github.com/ansys/pymapdl/actions/runs/9693282743

GitHub
Pythonic interface to MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 27, 2024
@germa89 germa89 enabled auto-merge (squash) June 27, 2024 13:01
@clatapie clatapie disabled auto-merge June 28, 2024 16:12
@clatapie clatapie enabled auto-merge (squash) June 28, 2024 16:12
@clatapie
Copy link
Contributor

clatapie commented Jun 28, 2024

I didn't mean to retest the changes as they will not be tested. I tried to cancel it but it was too late. Sorry about it!

@clatapie clatapie merged commit cda716a into main Jun 28, 2024
39 of 40 checks passed
@clatapie clatapie deleted the ci/fixing-tests-not-running-on-schedule branch June 28, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants