-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improving if to match also schedule and workflow_dispatch #3223
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3223 +/- ##
===========================================
- Coverage 86.63% 63.02% -23.62%
===========================================
Files 52 53 +1
Lines 9550 9625 +75
===========================================
- Hits 8274 6066 -2208
- Misses 1276 3559 +2283 |
Tested on
|
I didn't mean to retest the changes as they will not be tested. I tried to cancel it but it was too late. Sorry about it! |
Description
The unit tests are not running currently because of the last reorg of the workflow steps done in #3171, because now they depends on the smoke tests which were not running previously on schedule or workflow dispatch.
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)