Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not deleting temporary file when remove_temp_dir_on_exit=True #3247

Merged
merged 21 commits into from
Jul 8, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 8, 2024

Description

Fix not removing temporary directory when remove_temp_dir_on_exit == True

Issue linked

Close #3246

Checklist

@germa89 germa89 requested a review from a team as a code owner July 8, 2024 08:39
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 8, 2024 08:39
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Jul 8, 2024
@germa89 germa89 self-assigned this Jul 8, 2024
@germa89 germa89 changed the title Fix/not-deleting-ansys-tmp-dir fix: not deleting temporary file when remove_temp_dir_on_exit=True Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.65%. Comparing base (587a0cb) to head (da3e76d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3247      +/-   ##
==========================================
+ Coverage   82.67%   86.65%   +3.98%     
==========================================
  Files          53       53              
  Lines        9625     9625              
==========================================
+ Hits         7957     8341     +384     
+ Misses       1668     1284     -384     

@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

Coverage issue related to #3250

tests/test_mapdl.py Outdated Show resolved Hide resolved
tests/test_mapdl.py Outdated Show resolved Hide resolved
@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

Pinging @clatapie for a quick review

@germa89 germa89 force-pushed the fix/not-deleting-ansys-tmp-dir branch from b9fedda to 3dd2f4b Compare July 8, 2024 15:35
@germa89 germa89 enabled auto-merge (squash) July 8, 2024 15:36
@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 66a75da into main Jul 8, 2024
51 of 60 checks passed
@germa89 germa89 deleted the fix/not-deleting-ansys-tmp-dir branch July 8, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporary directory is not removed when remove_temp_dir_on_exit = True
2 participants