fix: not deleting temporary file when remove_temp_dir_on_exit=True

doc/changelog.d/3247.fixed.md

@@ -0,0 +1 @@
+fix: not deleting temporary file when ``remove_temp_dir_on_exit``=True

src/ansys/mapdl/core/launcher.py

@@ -516,9 +516,9 @@ def launch_grpc(
             proc = get_process_at_port(port)
             if proc:
                 if is_ansys_process(proc):
-                    raise PortAlreadyInUseByAnMAPDLInstance
+                    raise PortAlreadyInUseByAnMAPDLInstance(port)
                 else:
-                    raise PortAlreadyInUse
+                    raise PortAlreadyInUse(port)
 
     pymapdl._LOCAL_PORTS.append(port)
 

src/ansys/mapdl/core/misc.py

@@ -525,7 +525,7 @@ def create_temp_dir(tmpdir=None, name=None):
     if not name:
         random_name = True
         letters_ = string.ascii_lowercase.replace("n", "")
-        name = random_string(10, letters_)
+        name = "ansys_" + random_string(10, letters_)
     else:
         random_name = False
 

tests/test_mapdl.py

@@ -1952,7 +1952,7 @@ def test_save_on_exit(mapdl, cleared):
     mapdl2 = launch_mapdl(
         license_server_check=False,
         additional_switches=QUICK_LAUNCH_SWITCHES,
-        port=mapdl.port + 1,
+        port=mapdl.port + 2,
     )
     mapdl2.parameters["my_par"] = "initial_value"
 
@@ -1969,7 +1969,7 @@ def test_save_on_exit(mapdl, cleared):
     mapdl2 = launch_mapdl(
         license_server_check=False,
         additional_switches=QUICK_LAUNCH_SWITCHES,
-        port=mapdl.port + 1,
+        port=mapdl.port + 2,
     )
     mapdl2.resume(db_path)
     if mapdl.version >= 24.2:
@@ -2310,7 +2310,7 @@ def test_use_vtk(mapdl):
 
 
 @requires("local")
-def test_remove_temp_dir_on_exit(mapdl, tmpdir):
+def test__remove_temp_dir_on_exit(mapdl, tmpdir):
     path = os.path.join(tempfile.gettempdir(), "ansys_" + random_string())
     os.makedirs(path)
     filename = os.path.join(path, "file.txt")
@@ -2328,6 +2328,23 @@ def test_remove_temp_dir_on_exit(mapdl, tmpdir):
     assert os.path.exists(path) is False
 
 
+@requires("local")
+@requires("nostudent")
+def test_remove_temp_dir_on_exit(mapdl):
+
+    mapdl_2 = launch_mapdl(remove_temp_dir_on_exit=True, port=mapdl.port + 21)
+    path_ = mapdl_2.directory
+    assert os.path.exists(path_)
+    assert all([psutil.pid_exists(pid) for pid in mapdl_2._pids])
+
+    mapdl_2.exit()
+    time.sleep(1.0)
+    assert not os.path.exists(path_)
+    assert not all([psutil.pid_exists(pid) for pid in mapdl_2._pids])
+
+    # checking also pids
+
+
 def test_sys(mapdl):
     assert "hi" in mapdl.sys("echo 'hi'")
 

tests/test_pool.py

@@ -83,6 +83,7 @@ def pool(tmpdir_factory):
             exec_file=EXEC_FILE,
             additional_switches=QUICK_LAUNCH_SWITCHES,
             nproc=NPROC,
+            wait=True,  # make sure that the pool is ready before testing
         )
     else:
         port2 = os.environ.get("PYMAPDL_PORT2", 50057)
@@ -92,6 +93,7 @@ def pool(tmpdir_factory):
             license_server_check=False,
             start_instance=False,
             port=[port, port2],
+            wait=True,
         )
 
     yield mapdl_pool