Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local tests always running as student #3251

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 8, 2024

Description

Because of ON_STUDENT env var, all the local and minimal tests were running as student. So some pool and CLI tests were not running.

Issue linked

Close #3250

Checklist

@germa89 germa89 requested a review from a team as a code owner July 8, 2024 14:17
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 8, 2024 14:17
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 8, 2024
@germa89 germa89 added CI/CD Related with CICD, Github Actions, etc bug Issue, problem or error in PyMAPDL labels Jul 8, 2024
@github-actions github-actions bot added the maintenance General maintenance of the repo (libraries, cicd, etc) label Jul 8, 2024
@germa89 germa89 changed the title Fix/local-always-running-as-student Fix/local tests always running as student Jul 8, 2024
@germa89 germa89 changed the title Fix/local tests always running as student fix: local tests always running as student Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (587a0cb) to head (e5d0203).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3251      +/-   ##
==========================================
+ Coverage   82.67%   84.21%   +1.54%     
==========================================
  Files          53       53              
  Lines        9625     9625              
==========================================
+ Hits         7957     8106     +149     
+ Misses       1668     1519     -149     

@germa89 germa89 enabled auto-merge (squash) July 8, 2024 14:35
@germa89 germa89 merged commit 4c3ad39 into main Jul 8, 2024
46 checks passed
@germa89 germa89 deleted the fix/local-always-running-as-student branch July 8, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local always runs as student
3 participants