-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supporting ´´to_dataframe()´´ for some bc list commands #3412
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3412 +/- ##
==========================================
- Coverage 85.13% 83.36% -1.78%
==========================================
Files 55 55
Lines 9925 9963 +38
==========================================
- Hits 8450 8306 -144
- Misses 1475 1657 +182 |
…apdl into feat/bc_list2dataframe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! However it seems that the coverage percentage is not high enough to pass. Ideally, you should add additional unit tests to check all the possible cases.
Pinging @germa89 for visibility.
Description
to_dataframe() support for the output of following list boundary conditions commands: DKLIST, DLLIST, DALIST, FKLIST, SFLLIST, BFKLIST, BFLLIST and BFALIST
Issue linked
N / A
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)