Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation (implicit conversion) for PHP 8.1 #11

Closed
wants to merge 13 commits into from

Conversation

petarmarj
Copy link

Migrate code to PHP 8.1 (fixing PHP Deprecated: Implicit conversion from float …).

Unclear: Do Swiss country coordinates always have to be integers?

@petarmarj
Copy link
Author

I fixed a few more deprecations. security-checker (see CONTRIBUTING-file) is no longer supported, psalm/codesniffer partly needed other config-files.

@WengerK
Copy link
Member

WengerK commented Jun 29, 2023

Whoo thx @petarmarj I did not notice your contribution before today ..... very sorry for my very very late reply.

I will work on the project on the few next days to run tests on the CI, once done I will merge dev in your branch to ensure stability and merge if working <3

@WengerK
Copy link
Member

WengerK commented Jun 29, 2023

Unclear: Do Swiss country coordinates always have to be integers?

Having discussed with geo-professionals in Switzerland, we should indeed handle floating numbers. Still this library is not 100% accurate as we use an approximation to transform coordinates.

.gitignore Outdated Show resolved Hide resolved
VERSION Outdated Show resolved Hide resolved
VERSION Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants