[#65872] replace querySelector with getElementById

antmicro · Sep 19, 2024 · bf6622c · bf6622c
1 parent 4d44712
commit bf6622c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/hooks/markdownMermaid.js b/src/hooks/markdownMermaid.js
@@ -37,7 +37,7 @@ const markdownItMermaid = (md, { preview, lineMap, parent }) => {
       cached = contentCache.get(new IMurMurHash(code, hashSeed).result());
     }
     const id = Math.random().toString().replace(".", "");
-    token.attrSet("data-mermaid-id", id);
+    token.attrSet("id", `mermaid-${id}`);
 
     if (cached) {
       token.attrSet("class", "mermaid");
@@ -49,7 +49,7 @@ const markdownItMermaid = (md, { preview, lineMap, parent }) => {
       container.style.visibility = "none";
       document.body.appendChild(container);
 
-      waitForElement(preview.current, `[data-mermaid-id="${id}"]`).then((el) => {
+      waitForElement(preview.current, `mermaid-${id}`).then((el) => {
         mermaid
           .render(`mermaid-${id}`, code, container)
           .then(({ svg }) => {

diff --git a/src/hooks/markdownReplacer.js b/src/hooks/markdownReplacer.js
@@ -49,7 +49,7 @@ class PreviewWrapper {
     const placeholderId = "placeholder-" + Math.random().toString().slice(2);
 
     promise
-      .then(waitForElement(this.preview, `#${placeholderId}`))
+      .then(waitForElement(this.preview, placeholderId))
       .then((result) => {
         setCached(input, result);
         this.fillPlaceholder(placeholderId, result);

diff --git a/src/utils.js b/src/utils.js
@@ -1,13 +1,13 @@
-export async function waitForElement(parent, selector) {
+export async function waitForElement(parent, id) {
   return new Promise((resolve) => {
-    const elem = parent.querySelector(selector);
+    const elem = parent.getElementById(id);
     if (elem) {
       resolve(elem);
       return;
     }
 
     const observer = new MutationObserver(() => {
-      const elem = parent.querySelector(selector);
+      const elem = parent.getElementById(id);
       if (elem) {
         observer.disconnect();
         resolve(elem);