Skip to content

Commit

Permalink
Fix some if conditions in Github workflows
Browse files Browse the repository at this point in the history
Two shell if conditions in .github/workflows/build.yml were not valid
syntactically. As a result, the "latest" images for the Antrea Agent and
Controller were not updated for almost 2 months (for the amd64 arch).

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
  • Loading branch information
antoninbas committed Sep 3, 2024
1 parent 15fdb1e commit 78dba15
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
show-progress: false
- name: Checking if image needs to be pushed
run: |
if [ ${{ github.repository }} == 'antrea-io/antrea' && ${{ github.event_name }} == 'push' && ${{ github.ref }} == 'refs/heads/main' ]; then
if [ "${{ github.repository }}" == "antrea-io/antrea" ] && [ "${{ github.event_name }}" == "push" ] && [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "push_needed=true" >> $GITHUB_ENV
echo "docker_driver=docker-container" >> $GITHUB_ENV
else
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
show-progress: false
- name: Checking if image needs to be pushed
run: |
if [ ${{ github.repository }} == 'antrea-io/antrea' && ${{ github.event_name }} == 'push' && ${{ github.ref }} == 'refs/heads/main' ]; then
if [ "${{ github.repository }}" == "antrea-io/antrea" ] && [ "${{ github.event_name }}" == "push" ] && [ "${{ github.ref }}" == "refs/heads/main" ]; then
echo "push_needed=true" >> $GITHUB_ENV
echo "docker_driver=docker-container" >> $GITHUB_ENV
else
Expand Down

0 comments on commit 78dba15

Please sign in to comment.