Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky test] TestServiceExternalIP/testServiceNodeFailure #6783

Open
antoninbas opened this issue Oct 31, 2024 · 0 comments · May be fixed by #6784
Open

[Flaky test] TestServiceExternalIP/testServiceNodeFailure #6783

antoninbas opened this issue Oct 31, 2024 · 0 comments · May be fixed by #6784
Assignees
@antoninbas
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@antoninbas
Copy link
Contributor

Describe the bug
I have observed the TestServiceExternalIP/testServiceNodeFailure e2e test fail in CI

=== RUN   TestServiceExternalIP/testServiceNodeFailure/IPv4_cluster
    egress_test.go:973: 
        	Error Trace:	/home/runner/work/antrea/antrea/test/e2e/egress_test.go:973
        	            				/home/runner/work/antrea/antrea/test/e2e/service_externalip_test.go:566
        	Error:      	Received unexpected error:
        	            	admission webhook "externalippoolvalidator.antrea.io" denied the request: range [169.254.100.0/30] overlaps with range [169.254.100.0/30] of pool test-service-pool-86dtz
        	Test:       	TestServiceExternalIP/testServiceNodeFailure/IPv4_cluster
        	Messages:   	Failed to create ExternalIPPool

I think the root cause is pretty clear: the previous test created an ExternalIPPool with the same range, and while it was successfully deleted, it can take some time for the Antrea controller (externalippoolvalidator) to register it: the informer cache needs to be updated.

While it would be easy to add a sleep after each test case, or event to retry creation of the ExternalIPPool when it fails with this error, it may be better to just use non-overlapping ranges across different test cases.
@antoninbas antoninbas added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Oct 31, 2024
@antoninbas antoninbas self-assigned this Oct 31, 2024
antoninbas added a commit to antoninbas/antrea that referenced this issue Oct 31, 2024
@antoninbas
Use non-overlapping IP ranges across e2e tests for ExternalIPPools
d133560 
To avoid some rare failures.

Fixes antrea-io#6783

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas linked a pull request Oct 31, 2024 that will close this issue
Open
antoninbas added a commit to antoninbas/antrea that referenced this issue Oct 31, 2024
@antoninbas
Use non-overlapping IP ranges across e2e tests for ExternalIPPools
a036895 
To avoid some rare failures.

Fixes antrea-io#6783

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use non-overlapping IP ranges across e2e tests for ExternalIPPools antoninbas/antrea
1 participant
@antoninbas