Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the prometheus group with 2 updates #6101

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2024

Bumps the prometheus group with 2 updates: github.com/prometheus/client_golang and github.com/prometheus/common.

Updates github.com/prometheus/client_golang from 1.18.0 to 1.19.0

Release notes

Sourced from github.com/prometheus/client_golang's releases.

v1.19.0

What's Changed

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427

New Contributors

Full Changelog: prometheus/client_golang@v1.18.0...v1.19.0

Changelog

Sourced from github.com/prometheus/client_golang's changelog.

1.19.0 / 2023-02-27

The module prometheus/common v0.48.0 introduced an incompatibility when used together with client_golang (See prometheus/client_golang#1448 for more details). If your project uses client_golang and you want to use prometheus/common v0.48.0 or higher, please update client_golang to v1.19.0.

  • [CHANGE] Minimum required go version is now 1.20 (we also test client_golang against new 1.22 version). #1445 #1449
  • [FEATURE] collectors: Add version collector. #1422 #1427
Commits
  • 77d4003 Add 1.19.0 changelog (#1451)
  • 14259fa Merge pull request #1448 from ywwg/owilliams/content-negotiation
  • 6d03920 deps: bump prometheus/common version
  • 353395b Remove support for go 1.19 (#1449)
  • 9dd5d2a Merge pull request #1445 from kavu/add_go122_metrics_test
  • c906a5e Add support for Go 1.22
  • 7ac9036 Merge pull request #1440 from prometheus/dependabot/github_actions/github-act...
  • 8c7e30f Merge pull request #1441 from prometheus/dependabot/go_modules/tutorial/whats...
  • 08769f8 Bump github.com/prometheus/common in /tutorial/whatsup
  • 83d5940 Bump the github-actions group with 2 updates
  • Additional commits viewable in compare view

Updates github.com/prometheus/common from 0.47.0 to 0.48.0

Release notes

Sourced from github.com/prometheus/common's releases.

v0.48.0

This release will require changes of code that relies on direct access to content-type format strings. See the PR linked below for work-arounds. Please file an issue if your use case doesn't work anymore.

What's Changed

Full Changelog: prometheus/common@v0.47.0...v0.48.0

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 12, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 6 times, most recently from 0c7ec94 to d628684 Compare March 20, 2024 02:42
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 5 times, most recently from 448b9f3 to 563f0ed Compare March 27, 2024 03:15
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch from 563f0ed to 5a5d02b Compare March 27, 2024 19:01
@antoninbas
Copy link
Contributor

Cannot merge this PR because of a build failure:

Error: ../../../go/pkg/mod/k8s.io/component-base@v0.29.2/metrics/testutil/metrics.go:73:59: undefined: expfmt.FmtText

expfmt.FmtText is removed in recent versions of github.com/prometheus/common. However, k8s.io/component-base uses an older version of the library, and the code has a reference to expfmt.FmtText (as shown in the build error). Until github.com/prometheus/common is updated in K8s, and until Antrea picks up the updated K8s libraries, we will not be able to bump up github.com/prometheus/common.

I will be keeping this PR open so that Dependabot doesn't create new ones.

@antoninbas
Copy link
Contributor

K8s PR which updates github.com/prometheus/client_golang and github.com/prometheus/common: kubernetes/kubernetes#123547

@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 6 times, most recently from 45fbbbb to 22cd19b Compare April 4, 2024 03:17
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 5 times, most recently from 6c2d036 to dd4a33e Compare April 12, 2024 03:55
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 3 times, most recently from 1901c08 to 4f42666 Compare April 19, 2024 03:45
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 5 times, most recently from 9754c97 to 62936c2 Compare April 26, 2024 03:19
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 5 times, most recently from 26c78ec to a40b7f6 Compare May 6, 2024 03:10
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch 2 times, most recently from 5c920a5 to 30b533f Compare May 8, 2024 03:57
Bumps the prometheus group with 2 updates: [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) and [github.com/prometheus/common](https://github.com/prometheus/common).


Updates `github.com/prometheus/client_golang` from 1.18.0 to 1.19.0
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.18.0...v1.19.0)

Updates `github.com/prometheus/common` from 0.47.0 to 0.48.0
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](prometheus/common@v0.47.0...v0.48.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prometheus
- dependency-name: github.com/prometheus/common
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: prometheus
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/prometheus-31bc27785c branch from 30b533f to a9061cb Compare May 9, 2024 03:19
Copy link
Contributor Author

dependabot bot commented on behalf of github May 10, 2024

Superseded by #6314.

@dependabot dependabot bot closed this May 10, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/prometheus-31bc27785c branch May 10, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant