Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Arm images from this repo using Github-hosted Arm runners #6486

Conversation

antoninbas
Copy link
Contributor

@antoninbas antoninbas commented Jun 25, 2024

Github-hosted Arm runners are now in Beta for Enterprise accounts, and available to all CNCF projects. We can use them to build Antrea Arm images for the Agent and Controller, instead of relying on a private Github repo with self-hosted Arm runners.

At the moment, we only migrate the building part (along with creation of the multi-image manifest), and we use the existing workflow in vmware-tanzu/antrea-build-infra for "asynchronous" testing of the Arm images. We will handle the migration of the testing part in the future.

As part of this change, we also push "base images" (antrea/openvswitch, antrea/base-ubuntu) for arm64 and arm/v7 to the registry. This is necessary for building the Antrea images with the Docker container build driver. The base images now have the architecture as a suffix in their names. They are not available as multi-platform image manifests.

For #6453

@antoninbas antoninbas force-pushed the build-arm-images-using-github-hosted-runners branch from eb11b19 to 5547bf7 Compare June 25, 2024 23:07
@antoninbas antoninbas added the area/build-release Issues or PRs related to building and releasing label Jun 25, 2024
@antoninbas antoninbas force-pushed the build-arm-images-using-github-hosted-runners branch 2 times, most recently from 2af7d69 to cb336ac Compare June 27, 2024 21:34
@antoninbas antoninbas closed this Jun 28, 2024
@antoninbas antoninbas reopened this Jun 28, 2024
@antoninbas antoninbas force-pushed the build-arm-images-using-github-hosted-runners branch 7 times, most recently from db551e1 to 2fa618f Compare September 13, 2024 18:50
@antoninbas antoninbas force-pushed the build-arm-images-using-github-hosted-runners branch 2 times, most recently from 3fb2c8f to 0a71649 Compare September 17, 2024 20:11
@antoninbas antoninbas marked this pull request as ready for review September 17, 2024 20:47
@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

  • A release candidate will be necessary to make sure that the modified build_tag.yml workflow works as expected
  • In order to test build.yml (in particular, the ability to create and push the multi-platorm manifest), a separate branch was used. See https://github.com/antrea-io/antrea/actions/runs/10910365192

Github-hosted Arm runners are now in Beta for Enterprise accounts, and
available to all CNCF projects. We can use them to build Antrea Arm
images for the Agent and Controller, instead of relying on a private
Github repo with self-hosted Arm runners.

At the moment, we only migrate the building part (along with creation of
the multi-image manifest), and we use the existing workflow in
vmware-tanzu/antrea-build-infra for "asynchronous" testing of the Arm
images. We will handle the migration of the testing part in the future.

As part of this change, we also push "base images" (antrea/openvswitch,
antrea/base-ubuntu) for arm64 and arm/v7 to the registry. This is
necessary for building the Antrea images with the Docker container build
driver. The base images now have the architecture as a suffix in their
names. They are not available as multi-platform image manifests.

For antrea-io#6453

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas force-pushed the build-arm-images-using-github-hosted-runners branch from 0a71649 to 8471ba9 Compare October 14, 2024 17:22
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

build/images/build-utils.sh Show resolved Hide resolved
build/images/test/Dockerfile Show resolved Hide resolved
build/images/test/Dockerfile Show resolved Hide resolved
build/images/build-utils.sh Show resolved Hide resolved
@antoninbas
Copy link
Contributor Author

Thanks for the review @tnqn @luolanzone

@antoninbas antoninbas merged commit c722fc3 into antrea-io:main Oct 23, 2024
57 of 69 checks passed
@antoninbas antoninbas deleted the build-arm-images-using-github-hosted-runners branch October 23, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-release Issues or PRs related to building and releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants