-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Arm images from this repo using Github-hosted Arm runners #6486
Merged
antoninbas
merged 1 commit into
antrea-io:main
from
antoninbas:build-arm-images-using-github-hosted-runners
Oct 23, 2024
Merged
Build Arm images from this repo using Github-hosted Arm runners #6486
antoninbas
merged 1 commit into
antrea-io:main
from
antoninbas:build-arm-images-using-github-hosted-runners
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
force-pushed
the
build-arm-images-using-github-hosted-runners
branch
from
June 25, 2024 23:07
eb11b19
to
5547bf7
Compare
antoninbas
added
the
area/build-release
Issues or PRs related to building and releasing
label
Jun 25, 2024
antoninbas
force-pushed
the
build-arm-images-using-github-hosted-runners
branch
2 times, most recently
from
June 27, 2024 21:34
2af7d69
to
cb336ac
Compare
antoninbas
force-pushed
the
build-arm-images-using-github-hosted-runners
branch
7 times, most recently
from
September 13, 2024 18:50
db551e1
to
2fa618f
Compare
antoninbas
force-pushed
the
build-arm-images-using-github-hosted-runners
branch
2 times, most recently
from
September 17, 2024 20:11
3fb2c8f
to
0a71649
Compare
/test-all |
|
luolanzone
reviewed
Oct 12, 2024
Github-hosted Arm runners are now in Beta for Enterprise accounts, and available to all CNCF projects. We can use them to build Antrea Arm images for the Agent and Controller, instead of relying on a private Github repo with self-hosted Arm runners. At the moment, we only migrate the building part (along with creation of the multi-image manifest), and we use the existing workflow in vmware-tanzu/antrea-build-infra for "asynchronous" testing of the Arm images. We will handle the migration of the testing part in the future. As part of this change, we also push "base images" (antrea/openvswitch, antrea/base-ubuntu) for arm64 and arm/v7 to the registry. This is necessary for building the Antrea images with the Docker container build driver. The base images now have the architecture as a suffix in their names. They are not available as multi-platform image manifests. For antrea-io#6453 Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
force-pushed
the
build-arm-images-using-github-hosted-runners
branch
from
October 14, 2024 17:22
0a71649
to
8471ba9
Compare
luolanzone
reviewed
Oct 23, 2024
tnqn
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
luolanzone
approved these changes
Oct 23, 2024
Thanks for the review @tnqn @luolanzone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github-hosted Arm runners are now in Beta for Enterprise accounts, and available to all CNCF projects. We can use them to build Antrea Arm images for the Agent and Controller, instead of relying on a private Github repo with self-hosted Arm runners.
At the moment, we only migrate the building part (along with creation of the multi-image manifest), and we use the existing workflow in vmware-tanzu/antrea-build-infra for "asynchronous" testing of the Arm images. We will handle the migration of the testing part in the future.
As part of this change, we also push "base images" (antrea/openvswitch, antrea/base-ubuntu) for arm64 and arm/v7 to the registry. This is necessary for building the Antrea images with the Docker container build driver. The base images now have the architecture as a suffix in their names. They are not available as multi-platform image manifests.
For #6453