Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error output to integration test TestGoBGPLifecycle #6532

Conversation

hongliangl
Copy link
Contributor

For #6501

The testGoBGPLifecycle gets failed occasionally, and it is not easy to reproduce the failure manually. Adding some error output to which the error occurs may help to resolve the issue.

@hongliangl hongliangl force-pushed the 20240627-fix-integration-flaky-test-1 branch from 0c24a77 to c123344 Compare July 18, 2024 06:36
@hongliangl hongliangl requested a review from tnqn July 18, 2024 06:36
test/integration/agent/gobgp_test.go Show resolved Hide resolved
test/integration/agent/gobgp_test.go Outdated Show resolved Hide resolved
test/integration/agent/gobgp_test.go Show resolved Hide resolved
@hongliangl hongliangl force-pushed the 20240627-fix-integration-flaky-test-1 branch from c123344 to 7c40f02 Compare August 6, 2024 09:54
tnqn
tnqn previously approved these changes Aug 6, 2024
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Aug 8, 2024

The job failed but the newly added error seems not helpful: https://github.com/antrea-io/antrea/actions/runs/10264321176/job/28398120609?pr=6532

@hongliangl
Copy link
Contributor Author

The job failed but the newly added error seems not helpful: https://github.com/antrea-io/antrea/actions/runs/10264321176/job/28398120609?pr=6532

It should be caused by the t.Errorf added in this commit.

@hongliangl
Copy link
Contributor Author

Maybe I need to refactor the test. I found this: osrg/gobgp#2262. There might be something wrong when starting multiple BGP processes in a host.

The testGoBGPLifecycle gets failed occasionally, and it is not easy
to reproduce the failure manually. Adding some error output
to which the error occurs may help to resolve the issue.

Signed-off-by: Hongliang Liu <lhongliang@vmware.com>
@hongliangl hongliangl force-pushed the 20240627-fix-integration-flaky-test-1 branch from 53673ee to 7c78d7b Compare August 9, 2024 08:56
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days. You can add a label "lifecycle/frozen" to skip stale checking.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2024
@hongliangl
Copy link
Contributor Author

Add a new PR #6807 and close this one.

@hongliangl hongliangl closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants