Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ubuntu to 24.04 (Noble) #6575

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

antoninbas
Copy link
Contributor

@antoninbas antoninbas commented Jul 30, 2024

Upgrade to ubuntu:24.04 in most places (except for a few build / test
images which will be updated later on). In particular ubuntu:24.04 is
now the base image for antrea/antrea-agent-ubuntu and
antrea/controller-ubuntu.

In order for our current version of OVS (2.17.7) to build correctly on
Ubuntu 24.04, some "recent" patches have to be applied manually.

After this change, the antrea/antrea-agent-ubuntu image is slightly
bigger (344MB -> 372MB uncompressed), and the size increase seems to be
driven by some systemd libraries.

@antoninbas antoninbas marked this pull request as draft July 30, 2024 21:28
@antoninbas
Copy link
Contributor Author

Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit.

build/images/ovs/apply-patches.sh Outdated Show resolved Hide resolved
@luolanzone
Copy link
Contributor

@XinShuYang could you check the base VM OS used in CI pipeline? We may consider to upgrade as well when doing DC migration.

@XinShuYang
Copy link
Contributor

@XinShuYang could you check the base VM OS used in CI pipeline? We may consider to upgrade as well when doing DC migration.

Our CI cluster contains both 20.04 and 22.04 VMs. For the migrated cluster, We are deploying 22.04 VM based on the verified image. For CAPV compatibility, I prefer upgrading VM OS in CI after the CAPV 24.04 image is released in https://github.com/kubernetes-sigs/cluster-api-provider-vsphere#kubernetes-versions-with-published-ovas .

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the typo is fixed

@antoninbas antoninbas changed the title Upgrade Ubuntu to 24.04 Upgrade Ubuntu to 24.04 (Noble) and Suricata to 7.0 Aug 2, 2024
@antoninbas antoninbas marked this pull request as ready for review August 2, 2024 22:33
luolanzone
luolanzone previously approved these changes Aug 5, 2024
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I found L7NetworkPolicy didn't run due to a bug in test script, created #6586 and we should rebase on it to validate if suricata 7.0 works.

@antoninbas
Copy link
Contributor Author

@tnqn Nice catch, I have merged your PR and rebased

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas antoninbas requested a review from tnqn August 5, 2024 18:16
@antoninbas
Copy link
Contributor Author

Given that I have been informed that Suricata 6 is now end of life (https://forum.suricata.io/t/suricata-6-is-now-end-of-life-eol/4790), I will use a separate patch to upgrade to Suricata 7. We will merge it first, and backport it to supported Antrea versions.

@antoninbas
Copy link
Contributor Author

Depends on #6589

@antoninbas antoninbas marked this pull request as draft August 5, 2024 20:01
@antoninbas antoninbas changed the title Upgrade Ubuntu to 24.04 (Noble) and Suricata to 7.0 Upgrade Ubuntu to 24.04 (Noble) Aug 28, 2024
@antoninbas antoninbas marked this pull request as ready for review August 28, 2024 18:43
@antoninbas
Copy link
Contributor Author

@tnqn PTAL

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

/test-kind-ipv6-all

@antoninbas
Copy link
Contributor Author

/test-e2e
/test-networkpolicy
/test-kind-ipv6-e2e
/test-kind-ipv6-conformance

tnqn
tnqn previously approved these changes Sep 10, 2024
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Upgrade to ubuntu:24.04 in most places (except for a few build / test
images which will be updated later on). In particular ubuntu:24.04 is
now the base image for antrea/antrea-agent-ubuntu and
antrea/controller-ubuntu.

In order for our current version of OVS (2.17.7) to build correctly on
Ubuntu 24.04, some "recent" patches have to be applied manually.

After this change, the antrea/antrea-agent-ubuntu image is slightly
bigger (344MB -> 372MB uncompressed), and the size increase seems to be
driven by some systemd libraries.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas
Copy link
Contributor Author

/test-all
/test-kind-ipv6-all

@antoninbas
Copy link
Contributor Author

/test-e2e

1 similar comment
@antoninbas
Copy link
Contributor Author

/test-e2e

The Python3 version has changed between Ubuntu 22.04 and 24.04

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas dismissed stale reviews from luolanzone and tnqn via 1c3f3e7 September 12, 2024 22:43
@antoninbas
Copy link
Contributor Author

/test-all
/test-kind-ipv6-all

@antoninbas
Copy link
Contributor Author

@tnqn @luolanzone can I get a new approval for this, I had to make a small change (see second commit)?

Copy link
Contributor

@Dyanngg Dyanngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit 5533f5b into antrea-io:main Sep 16, 2024
54 of 61 checks passed
@antoninbas antoninbas deleted the upgrade-to-ubuntu-24.04 branch September 16, 2024 20:04
@antoninbas antoninbas added the action/release-note Indicates a PR that should be included in release notes. label Sep 16, 2024
hangyan pushed a commit to hangyan/antrea that referenced this pull request Oct 29, 2024
Upgrade to ubuntu:24.04 in most places (except for a few build / test
images which will be updated later on). In particular ubuntu:24.04 is
now the base image for antrea/antrea-agent-ubuntu and
antrea/controller-ubuntu.

In order for our current version of OVS (2.17.7) to build correctly on
Ubuntu 24.04, some "recent" patches have to be applied manually.

After this change, the antrea/antrea-agent-ubuntu image is slightly
bigger (344MB -> 372MB uncompressed), and the size increase seems to be
driven by some systemd libraries.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants