Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/vmware/go-ipfix to v0.11.0 #6639

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

antoninbas
Copy link
Contributor

No description provided.

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

/test-conformance
/test-kind-ipv6-e2e
/test-kind-ipv6-only-e2e

@antoninbas
Copy link
Contributor Author

/test-all
/test-kind-ipv6-e2e
/test-kind-ipv6-only-e2e

@antoninbas antoninbas marked this pull request as ready for review August 30, 2024 22:34
@antoninbas antoninbas marked this pull request as draft August 31, 2024 02:41
@antoninbas antoninbas force-pushed the bump-go-ipfix branch 2 times, most recently from 0b8d21b to a4d4664 Compare September 6, 2024 17:20
@antoninbas antoninbas marked this pull request as ready for review September 6, 2024 18:17
@antoninbas antoninbas changed the title Bump github.com/vmware/go-ipfix to v0.10.0 Bump github.com/vmware/go-ipfix to v0.10.1 Sep 6, 2024
tnqn
tnqn previously approved these changes Sep 10, 2024
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heanlan
Copy link
Contributor

heanlan commented Sep 12, 2024

Do you think it is necessary to also upgrade antrea/ipfix-collector image tag in E2E test? https://github.com/search?q=repo%3Aantrea-io%2Fantrea%20antrea%2Fipfix-collector&type=code

@antoninbas
Copy link
Contributor Author

@heanlan Thanks for pointing it out. I am probably going to release go-ipfix v0.11.0 soon actually, and I'll update this PR accordingly afterwards

The new version includes several improvements and bug fixes.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas changed the title Bump github.com/vmware/go-ipfix to v0.10.1 Bump github.com/vmware/go-ipfix to v0.11.0 Sep 26, 2024
@antoninbas
Copy link
Contributor Author

@heanlan this PR is ready to be reviewed again. It now uses go-ipfix v0.11.0 (latest release) and the correct tag for antrea/ipfix-collector.

@antoninbas
Copy link
Contributor Author

/test-all
/test-kind-ipv6-e2e
/test-kind-ipv6-only-e2e

Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas antoninbas merged commit a60f535 into antrea-io:main Sep 27, 2024
55 of 60 checks passed
@antoninbas antoninbas deleted the bump-go-ipfix branch September 27, 2024 22:34
hangyan pushed a commit to hangyan/antrea that referenced this pull request Oct 29, 2024
The new version includes several improvements and bug fixes.

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants