Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliver test images to CAPV nodes to avoid rate limit issue #6654

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

XinShuYang
Copy link
Contributor

@XinShuYang XinShuYang commented Sep 5, 2024

  • Increase the disk size of CAPV nodes for image storage.
  • Deliver test images from the image node to CAPV nodes.

@XinShuYang
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor

@XinShuYang Can we move this forward? Is it helping bypass rate limiting for pull?

@XinShuYang
Copy link
Contributor Author

@XinShuYang Can we move this forward? Is it helping bypass rate limiting for pull?

Sure. I believe this workaround can resolve the current rate limit issue. Since we've logged into the Docker account on the image node, there should be no pull rate limit when pulling images on this node. We can then distribute the necessary images to any new created nodes in the CAPV cluster.

@XinShuYang XinShuYang marked this pull request as ready for review September 11, 2024 03:15
@XinShuYang
Copy link
Contributor Author

/test-all

@XinShuYang
Copy link
Contributor Author

/test-all

IP=$2
tag=$3

docker pull ${image} && docker save -o image.tar ${image}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After copy to capv nodes , need to clean up local tar file i.e image.tar , also can inspect the image if we want to avoid same image pull again !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the implementation to pull the same image only once.

@XinShuYang
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor

Sure. I believe this workaround can resolve the current rate limit issue. Since we've logged into the Docker account on the image node, there should be no pull rate limit when pulling images on this node. We can then distribute the necessary images to any new created nodes in the CAPV cluster.

There is a limit for authenticated users, it's 200 pulls per 6 hour period. If we can get our Sponsored OSS status back, then there will be no limit.

antoninbas
antoninbas previously approved these changes Sep 11, 2024
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoninbas
Copy link
Contributor

@XinShuYang all the Jenkins jobs have been stuck waiting for an executor

* Increase the disk size of CAPV nodes for image storage.
* Deliver test images from the image node to CAPV nodes.

Signed-off-by: Shuyang Xin <gavinx@vmware.com>
@XinShuYang
Copy link
Contributor Author

XinShuYang commented Sep 11, 2024

@XinShuYang all the Jenkins jobs have been stuck waiting for an executor

The Sonobuoy test is stuck because its default image pull policy is still Always...

@XinShuYang
Copy link
Contributor Author

/test-all

@antoninbas antoninbas merged commit afdd261 into antrea-io:main Sep 12, 2024
52 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants