-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update crictl version to v1.31.1 #6733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have noticed this warning, however this is not a great approach to tackling it:
- IMO, we shouldn't add a tag that doesn't exist (such as
latest
forantrea/base-ubuntu
) - having a specific version as the tag (e.g.,
ARG GO_VERSION=1.23
) defeats the purpose of having one source of truth for the version, and means a larger diff when bumping up the dependency - when building and forgetting the tag (e.g., from a script), it's better to have an error (missing tag) rather than build with the wrong "default" tag. This type of issue can create surprising behaviors and be hard to troubleshoot.
#6486 should reduce the amount of warnings. We could do something similar for the golang
image and use a build context. Otherwise, I would suggest silencing that specific warning for now.
8531d9d
to
bcb9a53
Compare
Hi @antoninbas I have reverted the change and made some cleanup only, PTAL, thanks. |
Ah, I just noticed that you already removed unused args in the PR #6486, thanks for that. I think we still need to update crictl's version to 1.31.1 but it's not critical, do you want to include the change in your PR or keep in this PR? |
I think we can have a dedicated PR to update the crictl version |
Signed-off-by: Lan Luo <luola@vmware.com>
bcb9a53
to
e7a29a0
Compare
Signed-off-by: Lan Luo <luola@vmware.com>
No description provided.