Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make llm serving template serverless #84

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Make llm serving template serverless #84

merged 3 commits into from
Feb 23, 2024

Conversation

ericl
Copy link
Contributor

@ericl ericl commented Feb 21, 2024

No description provided.

Signed-off-by: Eric Liang <ekhliang@gmail.com>
@@ -0,0 +1,16 @@
import requests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to make it a bit more friendly out of the box

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update needed to readme to run serve run main:my_app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already there, I just created the file so the user doesn't need to copy paste code from the markdown cell.

Copy link
Contributor

@shomilj shomilj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@shomilj shomilj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/anyscale/product/pull/26531 needs to land before this can merge

@akshay-anyscale
Copy link
Contributor

@shomilj is multi-az stuff in serverless defaults

@shomilj
Copy link
Contributor

shomilj commented Feb 22, 2024

@shomilj is multi-az stuff in serverless defaults

No, this is unrelated to serverless - this is something that should be set in the base advanced config if desired. So we should keep these around in the compute configs @ericl:

aws:
  TagSpecifications:
    - ResourceType: instance
      Tags:
        - Key: as-feature-enable-multi-az-serve
          Value: "true"
        - Key: as-feature-multi-zone
          Value: "true"

@gvspraveen
Copy link
Contributor

gvspraveen commented Feb 22, 2024

No, this is unrelated to serverless - this is something that should be set in the base advanced config if desired.

@shomilj ooc, will serverless config only add worker_node_types?

@shomilj
Copy link
Contributor

shomilj commented Feb 22, 2024

@gvspraveen yes, "serverless" is just "auto_select_worker_config" set to true - all it does is handle worker node types

@ericl
Copy link
Contributor Author

ericl commented Feb 22, 2024

No, this is unrelated to serverless - this is something that should be set in the base advanced config if desired. So we should keep these around in the compute configs @ericl:

@shomilj any reason not to enable this by default for all OA configs? It seems strange we have these configs that are required for the top CUJ that are off by default.

@shomilj
Copy link
Contributor

shomilj commented Feb 23, 2024

https://github.com/anyscale/product/pull/26531 has been merged.

We will likely enable multi-zone by default for OA workloads -- will tackle that as a separate work item this upcoming sprint. So I would add back the aws / gcp advanced config blocks for now, but other than that this is ready to go :)

Signed-off-by: Eric Liang <ekhliang@gmail.com>
@ericl ericl merged commit 5377a9a into main Feb 23, 2024
1 check passed
anmscale pushed a commit that referenced this pull request Jun 22, 2024
Make llm serving template serverless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants