Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove social links box #405

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

ctubbsii
Copy link
Member

@ctubbsii ctubbsii commented Sep 8, 2023

More prominently indicate that our use of Twitter is inactive, due to the inability of the PMC to properly share the responsibilities of maintaining our presence there (TweetDeck is now a paid premium service, and we cannot use it any longer for free) and the lack of interest from the PMC in maintaining our presence there.

Remove social links box on main page by:

  • Removing reference to our defunct Twitter presence, due to the
    inability of the PMC to properly share the responsibilities of
    maintaining our presence there (TweetDeck is now a paid premium
    service, and we cannot use it any longer for free) and the lack of
    interest from the PMC in maintaining our presence there
  • Move Linked in information to the people page
  • Remove redundant GitHub link
  • Remove unused images and includes pages related to social media

Copy link
Member

@DomGarguilo DomGarguilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Here is a screenshot with these changes:
image

@ctubbsii
Copy link
Member Author

ctubbsii commented Sep 8, 2023

Oh, I guess I didn't realize this got rendered to the main page. I was thinking it was only on a separate page of links or on the contact-us page. For the main page, I think it should probably just be omitted.

Also, I'm not sure why LinkedIn is so prominent on our main page. It's only tangentially related to the project, and as far as I am aware, the group there is not maintained by the PMC. That should probably be a footnote on the people page rather than so prominent on the main page. It certainly shouldn't be conveyed higher in the list than the GitHub link to the repo, which is actually a PMC-maintained space.

I think I'm going to take another pass at this.

Remove social links box on main page by:

* Removing reference to our defunct Twitter presence, due to the
  inability of the PMC to properly share the responsibilities of
  maintaining our presence there (TweetDeck is now a paid premium
  service, and we cannot use it any longer for free) and the lack of
  interest from the PMC in maintaining our presence there
* Move Linked in information to the people page
* Remove redundant GitHub link
* Remove unused images and includes pages related to social media
@ctubbsii ctubbsii force-pushed the mark-twitter-inactive branch from b834cb7 to 6b5cb16 Compare November 21, 2023 00:54
@ctubbsii ctubbsii changed the title Mark the link to our Twitter presence as inactive Remove social links box Nov 21, 2023
@ctubbsii ctubbsii requested a review from DomGarguilo November 21, 2023 00:55
@ctubbsii
Copy link
Member Author

Updated title and description to match these new changes... this time, I got rid of the box entirely from the page. It's not really needed there.

@ctubbsii ctubbsii merged commit f9422ba into apache:main Nov 29, 2023
1 check passed
@ctubbsii ctubbsii deleted the mark-twitter-inactive branch November 29, 2023 07:18
Copy link
Member

@DomGarguilo DomGarguilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didnt get a change to re-review before this was merged but everything LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants