-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bootstrap map files #426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment at #425 (comment) that suggested we just use the non-minified versions instead of bothering with these .map files.
In a27b55f I replaced the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me. Two questions I have are:
- Does this resolve the issue you were seeing?
- Is it worth changing the other minified resources to their regular versions also?
Yes, the error I was seeing is no longer present.
It is an easy enough change to make so I could convert the others too as part of a version bump in a separate PR. |
I guess I spoke too soon. After a while of the development docker container running, I still see the original errors (except now they mention the non minified versions):
|
Hmm, that's very weird. I'd like to try to reproduce this. I have no idea what is creating these errors. The files themselves are definitely not needed. |
I am running things in the development docker container. Should pop up there. The files are refferenced at the bottom of the files. For example:
It has the same for the non minified too. Edit: One option to stop seeing these errors would be to remove the comments in the files mentioned above but I am not sure if we want to modify the files. |
The Dockerfile just seems to run I did find https://stackoverflow.com/questions/57582243/no-sourcemap-for-css |
Also, perhaps we can just ignore the errors? They seem to be false positives of some sort anyway. I don't think they represent an actual error in anything. |
Yea it should be fine to ignore them. Especially if they are only appearing in the development docker output. |
Fixes #425
Adds the map files for the minified boostrap resources added in #423
These map files were download from https://github.com/twbs/bootstrap/archive/v5.3.1.zip