Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap map files #426

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Add bootstrap map files #426

merged 2 commits into from
Jul 12, 2024

Conversation

DomGarguilo
Copy link
Member

Fixes #425

Adds the map files for the minified boostrap resources added in #423

These map files were download from https://github.com/twbs/bootstrap/archive/v5.3.1.zip

@DomGarguilo DomGarguilo self-assigned this May 2, 2024
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a comment at #425 (comment) that suggested we just use the non-minified versions instead of bothering with these .map files.

@DomGarguilo
Copy link
Member Author

In a27b55f I replaced the .min and .map files with the single non-minified versions. I also took this opportunity to bump to bootstrap version 5.3.3

@DomGarguilo DomGarguilo requested a review from ctubbsii July 12, 2024 15:51
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. Two questions I have are:

  • Does this resolve the issue you were seeing?
  • Is it worth changing the other minified resources to their regular versions also?

@DomGarguilo
Copy link
Member Author

These changes look good to me. Two questions I have are:

  • Does this resolve the issue you were seeing?

Yes, the error I was seeing is no longer present.

  • Is it worth changing the other minified resources to their regular versions also?

It is an easy enough change to make so I could convert the others too as part of a version bump in a separate PR.

@DomGarguilo DomGarguilo merged commit dd90552 into apache:main Jul 12, 2024
1 check passed
@DomGarguilo DomGarguilo deleted the mapFiles branch July 12, 2024 18:39
@DomGarguilo
Copy link
Member Author

These changes look good to me. Two questions I have are:

  • Does this resolve the issue you were seeing?

Yes, the error I was seeing is no longer present.

I guess I spoke too soon. After a while of the development docker container running, I still see the original errors (except now they mention the non minified versions):

[2024-07-17 23:48:45] ERROR `/css/bootstrap/5.3.3/dist/css/bootstrap.css.map' not found.
[2024-07-17 23:48:45] ERROR `/js/bootstrap/5.3.3/dist/js/bootstrap.bundle.js.map' not found.

@ctubbsii
Copy link
Member

Hmm, that's very weird. I'd like to try to reproduce this. I have no idea what is creating these errors. The files themselves are definitely not needed.

@DomGarguilo
Copy link
Member Author

DomGarguilo commented Jul 19, 2024

Hmm, that's very weird. I'd like to try to reproduce this. I have no idea what is creating these errors. The files themselves are definitely not needed.

I am running things in the development docker container. Should pop up there. The files are refferenced at the bottom of the files. For example:

//# sourceMappingURL=bootstrap.bundle.js.map

It has the same for the non minified too.

Edit:
If you want to reproduce with the regular files (not .min you can checkout my branch: https://github.com/DomGarguilo/accumulo-website/tree/nonMinifiedResources).

One option to stop seeing these errors would be to remove the comments in the files mentioned above but I am not sure if we want to modify the files.

@ctubbsii
Copy link
Member

Hmm, that's very weird. I'd like to try to reproduce this. I have no idea what is creating these errors. The files themselves are definitely not needed.

I am running things in the development docker container. Should pop up there. The files are refferenced at the bottom of the files. For example:

The Dockerfile just seems to run bundle exec jekyll serve. I don't get any errors when I run that locally, so I'm very curious what's different. Perhaps it's a different version of jekyll, or some dependency? I'm not sure where the errors are appearing, or which command they are coming from. I don't have Docker set up, so I can't reproduce this.

I did find https://stackoverflow.com/questions/57582243/no-sourcemap-for-css
This might be some difference in default behavior coming from different versions of jekyll, or sass, or something. Perhaps we can force one behavior or another by setting configuration?

@ctubbsii
Copy link
Member

Also, perhaps we can just ignore the errors? They seem to be false positives of some sort anyway. I don't think they represent an actual error in anything.

@DomGarguilo
Copy link
Member Author

Also, perhaps we can just ignore the errors? They seem to be false positives of some sort anyway. I don't think they represent an actual error in anything.

Yea it should be fine to ignore them. Especially if they are only appearing in the development docker output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when running development docker container - map files not found
2 participants