-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove sending of task logs in otel traces (#43943)
This was sending task logs from the scheduler has two problems: 1. It blocks the scheduling loop reading remote logs -- a huge performance foot-gun for anyone that turns this feature on 2. Sending task logs in a span seems too large, and way too verbose to provide any use in a span.
- Loading branch information
Showing
3 changed files
with
5 additions
and
33 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Remove the ``traces`` ``otel_task_log_event`` event config option and feature | ||
|
||
This was sending the task logs form the scheduler, and would be a huge | ||
scheduling performance hit (blocking the entire all scheduling while it was | ||
fetching logs to attach to the trace) |