Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove execution_date and logical_date from arguments where function/API is used to look up a DAG run #42338

Open
1 task done
uranusjr opened this issue Sep 19, 2024 · 4 comments
Open
1 task done

Remove execution_date and logical_date from arguments where function/API is used to look up a DAG run #42338

uranusjr opened this issue Sep 19, 2024 · 4 comments
Assignees
@sunank200
Labels
AIP-83 Remove Execution Date Unique Constraint from DAG Run airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:core
Milestone
Airflow 3.0.0

Comments

@uranusjr
Copy link
Member

Body

Since we’re dropping the unique constraint, those arguments no longer can look up a unique DAG run. Those functions should already take a run_id, which should be used instead going forward.

The use of execution/logical date in those functions should have already been deprecated. If not, a deprecation warning should be added to the 2.x branch to be released in 2.11.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@uranusjr uranusjr added airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes AIP-83 Remove Execution Date Unique Constraint from DAG Run labels Sep 19, 2024
@dosubot dosubot bot added the area:core label Sep 19, 2024
@uranusjr uranusjr added this to the Airflow 3.0.0 milestone Sep 19, 2024
@sunank200
Copy link
Collaborator

sunank200 commented Sep 23, 2024 •
edited
Loading

Created a draft PR #42404.

@sunank200
Copy link
Collaborator

Currently fixing the tests and making CI green.

@sunank200
Copy link
Collaborator

I have removed the execution_date completely. We have 202 files changed as part of this PR #42404 @uranusjr can you take a look, please for early review? I have renamed the execution date in the TaskInstance model and other classes. I am now working on fixing tests.

@sunank200
Copy link
Collaborator

I have fixed most of the tests. I am currently fixing the test for Core, WWW, API and CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunank200 sunank200

Labels
AIP-83 Remove Execution Date Unique Constraint from DAG Run airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes area:core
Projects
AIP-83 Remove execution date
Status: In progress
Milestone
Airflow 3.0.0
Development

No branches or pull requests
2 participants
@uranusjr @sunank200