Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage PEP 669 setting for tests #38213

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 16, 2024

The coverage fix in #38194 was wrongly applied to Helm tests, not to the unit tests 🤦. This PR sets it in the right place.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The coverage fix in apache#38194 was wrongly applied to Helm tests, not to
the unit tests 🤦. This PR sets it in the right place.
@potiuk potiuk force-pushed the disable-coverage-for-python-3-12 branch from d82026b to f211025 Compare March 16, 2024 15:52
@potiuk
Copy link
Member Author

potiuk commented Mar 16, 2024

Actually I had to set it even one layer deeper - in the bash script - because it was not even propagated to inside the container 🤦

@potiuk
Copy link
Member Author

potiuk commented Mar 16, 2024

diagnostics is useful :)

@potiuk
Copy link
Member Author

potiuk commented Mar 16, 2024

OK. This time I am sure it is enabled:

Screenshot 2024-03-16 at 17 38 45

@potiuk potiuk merged commit 6c99fcc into apache:main Mar 16, 2024
86 of 87 checks passed
@potiuk potiuk deleted the disable-coverage-for-python-3-12 branch March 16, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants