Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mothership PR] MVP of AIP-69 - A experimental usable version of Edge Executor #40900

Closed

Conversation

jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Jul 20, 2024

This PR is a DRAFT to further get to a MVP release of AIP-69. DO NOT MERGE (yet) - but please feedback on it if you like.

It is a continuation of PR #40224 which was a kind of PoC and step-by-step more stuff came onto this on top.

This is a kind of "Mothership" PR where all contributions are collected. Small parts will be separately opened as PR to get on main and finally I'd split this PR up into smaller pieces for easier review. In this PR all parts and work is collected.

Please treat this as experimental as noted in the docs, it is not expected to be rock-solid but a first usable version. It can be used to distribute the first task. Status of implementation is tracked in docs/apache-airflow-providers-edge/edge_executor.rst below headline "Feature Backlog of MVP to Release Readiness" in this PR.

If you want to test it you can:

  • Checkout the branch
  • Run breeze start-airflow --load-example-dags --backend postgres --executor EdgeExecutor
  • The Edge Worker will be start in one panel by breeze
  • A task can be run, e.g. use example DAG example_python_operator or the Integration Test with a bit more complexity (this integration test has been moved to providers/src/airflow/providers/edge/example_dags/integration_test.py). Wohoo!
    image
  • If you open the UI you will see an additional plugin loaded in the menu "Admin" -> "Remote Worker Status":
    image

Based on progress and time I will sometimes re-base and push changes to this branch. But it will not be something that will be review-able.
I will not add any migration logic in case of updates for the additional tables in DB Scheme. If I update the draft PR and DB schema changes, DB might need to be reset. Of course migration support would need to be added before a "real" release.

@jscheffl jscheffl added this to the Airflow 2.10.0 milestone Jul 20, 2024
@boring-cyborg boring-cyborg bot added area:dev-tools area:Executors-core LocalExecutor & SequentialExecutor area:providers labels Jul 20, 2024
@jscheffl jscheffl force-pushed the feature/aip-69-remote-executor-mvp branch from a10f33c to 91dff32 Compare July 20, 2024 12:20
@jscheffl jscheffl force-pushed the feature/aip-69-remote-executor-mvp branch 4 times, most recently from a260cf6 to 120710a Compare July 27, 2024 20:02
@jscheffl jscheffl removed this from the Airflow 2.10.0 milestone Aug 8, 2024
@jscheffl jscheffl force-pushed the feature/aip-69-remote-executor-mvp branch 12 times, most recently from 3f97faa to c2f2700 Compare August 21, 2024 09:58
@jscheffl jscheffl force-pushed the feature/aip-69-remote-executor-mvp branch 7 times, most recently from 1959171 to 60d77e7 Compare August 25, 2024 09:53
@jscheffl jscheffl force-pushed the feature/aip-69-remote-executor-mvp branch from d5c7cf9 to 5495dad Compare October 18, 2024 04:55
@jscheffl
Copy link
Contributor Author

All detailled split PRs have been merged, so this is not needed anymore. All features are now on main

@jscheffl jscheffl closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-69 Edge Executor area:dev-tools area:Executors-core LocalExecutor & SequentialExecutor area:providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant