WIP Add trigger to new UI #43058
Closed
WIP Add trigger to new UI #43058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
reviewed
Oct 16, 2024
| isOpen={isOpen} | ||
| onClose={onClose} | ||
| submitButton={ | ||
| <Button isLoading={isSubmitting} onClick={handleSubmit(onTrigger)}> |
There was a problem hiding this comment.
Suggested change
| <Button isLoading={isSubmitting} onClick={handleSubmit(onTrigger)}> | |
| <Button isLoading={isSubmitting} onClick={() => handleSubmit(onTrigger)}> |
We need to pass the function not the return value of a called function.
There was a problem hiding this comment.
I tried this - also as eslint is cmplaining about this... but then it is not working...
There was a problem hiding this comment.
What error did you get?
Sometimes I need to run pnpm install before linting.
In vscode, once in a while I also need to cmd+shift+P and restart the eslint server:
jscheffl
force-pushed
the
feature/add-trigger-to-new-ui
branch
from
1a5d4df
to
25251a1
Compare
jscheffl
force-pushed
the
feature/add-trigger-to-new-ui
branch
from
25251a1
to
c074d54
Compare
jscheffl
force-pushed
the
feature/add-trigger-to-new-ui
branch
from
c074d54
to
6929d37
Compare
|
Close in favor of moving forward with #43367 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft to add a new Trigger UI
WIP: