Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the public endpoint Get DAG Source to FastAPI #43084

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Migrate the public endpoint Get DAG Source to FastAPI #43084

merged 2 commits into from
Oct 30, 2024

Conversation

omkar-foss
Copy link
Collaborator

Closes: #42876
Related: #42370

This migrates the Get DAG Source API from api_connexion to api_fastapi.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Oct 16, 2024
@omkar-foss omkar-foss force-pushed the aip-84/dags/get-dag-source branch 3 times, most recently from 3042ffe to 823df79 Compare October 16, 2024 20:10
@omkar-foss omkar-foss marked this pull request as ready for review October 17, 2024 10:15
@omkar-foss omkar-foss force-pushed the aip-84/dags/get-dag-source branch 2 times, most recently from 13706b3 to c4e75f1 Compare October 18, 2024 08:06
@omkar-foss omkar-foss mentioned this pull request Oct 18, 2024
Merged
pierrejeambrun
pierrejeambrun reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

airflow/api_fastapi/core_api/routes/public/dag_sources.py Outdated Show resolved Hide resolved
tests/api_fastapi/core_api/routes/public/test_dag_sources.py Outdated Show resolved Hide resolved
pierrejeambrun
pierrejeambrun reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing the @mark_fastapi_migration_done

pierrejeambrun
pierrejeambrun reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR updated

airflow/api_connexion/endpoints/dag_source_endpoint.py Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/dag_sources.py Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/dag_sources.py Outdated Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/dag_sources.py Show resolved Hide resolved
airflow/api_fastapi/core_api/routes/public/dag_sources.py Show resolved Hide resolved
@pierrejeambrun pierrejeambrun added the legacy api Whether legacy API changes should be allowed in PR label Oct 25, 2024
@omkar-foss omkar-foss marked this pull request as draft October 29, 2024 06:06
@omkar-foss
Copy link
Collaborator Author

Please ignore the request for review notification, reviewers got auto-added due to a large diff w.r.t main. I'll correct the reviewers list manually.

My apologies for the spam! :)

@omkar-foss omkar-foss force-pushed the aip-84/dags/get-dag-source branch 2 times, most recently from 5127bff to a1eea28 Compare October 29, 2024 07:08
@omkar-foss omkar-foss marked this pull request as ready for review October 29, 2024 07:46
@omkar-foss
Copy link
Collaborator Author

All conversations resolved, synced with main and conflicts resolved. PR ready for review.

pierrejeambrun
pierrejeambrun approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Needs rebasing to fix conflicts but ready to merge after that.

@omkar-foss
Copy link
Collaborator Author

Nice. Needs rebasing to fix conflicts but ready to merge after that.

Synced with main and fixed conflicts! ✅

@pierrejeambrun
Copy link
Member

Nice work, thanks

@pierrejeambrun pierrejeambrun merged commit 64d8f4f into apache:main Oct 30, 2024
52 checks passed
@omkar-foss omkar-foss deleted the aip-84/dags/get-dag-source branch November 4, 2024 05:35
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@omkar-foss @pierrejeambrun @ellisms
Migrate the public endpoint Get DAG Source to FastAPI (apache#43084)
de5b1df 
* Migrate public endpoint Get DAG Source to FastAPI, with main resynced

Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>

* Re-run static checks

---------

Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@jscheffl jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. legacy api Whether legacy API changes should be allowed in PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-84 Migrate the public endpoint Get DAG Source to FastAPI
2 participants
@omkar-foss @pierrejeambrun