added "name" and "hostname" to template_fields in KubernetesPodOperator #43601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eilon246810
requested review from
jedcunningham and
hussein-awala
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
providers/src/airflow/providers/cncf/kubernetes/operators/pod.py
Outdated
Show resolved
Hide resolved
amoghrajesh
reviewed
Nov 2, 2024
providers/src/airflow/providers/cncf/kubernetes/operators/pod.py
Outdated
Show resolved
Hide resolved
Comment on lines
262
to
+264
| "kubernetes_conn_id", | ||
| "name", | ||
| "hostname", |
There was a problem hiding this comment.
Can you please add tests that cover this change in test_pod.py?
|
I see I have some tests failing, setting PR to draft until I fix these. |
|
The tests seem to fail because some of them mock the I need help here - what is the way to solve this in your opinion? |
romsharon98
reviewed
Nov 14, 2024
| @@ -594,6 +596,8 @@ def extract_xcom(self, pod: k8s.V1Pod) -> dict[Any, Any] | None: | |||
|
|
|||
| def execute(self, context: Context): | |||
| """Based on the deferrable parameter runs the pod asynchronously or synchronously.""" | |||
| context["task"].name = self._set_name(context["task"].name) # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
you don't need to use the context here.
you can just use self.name like this
Suggested change
| context["task"].name = self._set_name(context["task"].name) # type: ignore[attr-defined] | |
| self.name = self._set_name(self.name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR closes: #43480.
It's a small change, which involves adding the
nameandhostnameto thetemplate_fieldsin theKubernetesPodOperator.I decided to use a different approach from the one suggested by the issue creator.
This was to avoid changing the class API by renaming
self.nametoself.pod_name.What do you think?