Move Asset user facing components to task_sdk #43773
Open
+887
−735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
Lee-W
force-pushed
the
move-asset-to-task-sdk
branch
6 times, most recently
from
c7ecee5
to
5c8d6e2
Compare
Lee-W
requested review from
bolkedebruin,
potiuk,
ashb,
jedcunningham,
mobuchowski,
eladkal,
o-nikolas,
uranusjr,
ryanahamilton,
bbovenzi,
pierrejeambrun,
jscheffl,
ephraimbuddy and
XD-DENG
as code owners
Lee-W
force-pushed
the
move-asset-to-task-sdk
branch
from
16ab769
to
9ffa9a2
Compare
Lee-W
changed the title
Lee-W
added
airflow3.0:breaking
Lee-W
force-pushed
the
move-asset-to-task-sdk
branch
3 times, most recently
from
4bba78f
to
17079b8
Compare
uranusjr
reviewed
Nov 8, 2024
| @@ -85,15 +85,15 @@ | |||
| "version": (".version", "", False), | |||
| # Deprecated lazy imports | |||
| "AirflowException": (".exceptions", "AirflowException", True), | |||
| "Dataset": (".assets", "Dataset", True), | |||
| "Dataset": (".sdk.definitions.asset", "Dataset", True), | |||
There was a problem hiding this comment.
We should also change the line for Asset right?
There was a problem hiding this comment.
I think we should keep it as Dataset. I think we're using the subclass Dataset(Asset) here
Lee-W
force-pushed
the
move-asset-to-task-sdk
branch
7 times, most recently
from
befbbbf
to
97d78b2
Compare
…on to return compat method
Lee-W
force-pushed
the
move-asset-to-task-sdk
branch
from
97d78b2
to
8ab526d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As part of AIP-72
Closes: #43619
What
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.