-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix asset name uri handling #43774
Draft
Lee-W
wants to merge
10
commits into
apache:main
Choose a base branch
from
astronomer:fix-asset-name-uri-handling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Fix asset name uri handling #43774
+157
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:serialization
area:webserver
Webserver related Issues
labels
Nov 7, 2024
TODOExtend the following test case to include more asset attributes
|
Lee-W
force-pushed
the
fix-asset-name-uri-handling
branch
from
November 11, 2024 06:28
32394ac
to
4726cc2
Compare
Lee-W
force-pushed
the
fix-asset-name-uri-handling
branch
from
November 11, 2024 11:07
4726cc2
to
0b6a309
Compare
Lee-W
force-pushed
the
fix-asset-name-uri-handling
branch
6 times, most recently
from
November 14, 2024 07:43
a57ed8b
to
9f9366d
Compare
Makes sense to me. Will take another look when this is ready for review. |
Lee-W
force-pushed
the
fix-asset-name-uri-handling
branch
from
November 14, 2024 09:18
9f9366d
to
8010f7c
Compare
…lude both uri and name
…clude both uri and name
…de both uri and name
…p fields (also AssetAlias group field)
Lee-W
force-pushed
the
fix-asset-name-uri-handling
branch
from
November 14, 2024 12:09
8010f7c
to
aee8f7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #43958
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.