Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-72: Add "Get Variable" endpoint for Execution API #43832

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Nov 8, 2024

This commit introduces a new endpoint, /execution/variable/{variable_key}, in the Execution API to retrieve Variables details.

Same as the Connections PR, it uses a placeholder check_connection_access function to validate task permissions for each request.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxil kaxil marked this pull request as ready for review November 8, 2024 16:54
@kaxil kaxil requested a review from ashb November 8, 2024 16:54
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few Qs/comments, but LGTM

This commit introduces a new endpoint, `/execution/variable/{variable_key}`, in the Execution API to retrieve Variables details.

Same as the Connections PR, it uses a placeholder `check_connection_access` function to validate task permissions for each request.
@kaxil kaxil merged commit 01302a1 into apache:main Nov 8, 2024
52 checks passed
@kaxil kaxil deleted the add-variables branch November 8, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants