-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backport action to workflow #43886
Add backport action to workflow #43886
Conversation
@amoghrajesh thanks for the suggestion :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fail to see where we configure the target branch.
ah it would take from the label, backport-to-v2-10-test, so here |
00a473d
to
05b0e01
Compare
Yeah, We will just have to create appropriate labels for all past versions. |
05b0e01
to
d0eca75
Compare
I rebased it to account for latest static check fixes. |
Yes agreed, not sure how to test? do we have any prs to backport? 😄 |
Absolutely: #43885 should be backported to all branches. Perfect candidate :D. I will rebase and create/apply backport branches when this one is merged :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool!
Do you prepare labels with a description such that we know what to pick.
Looking forward to automate the manual burden!
I will do it when backporting #43885 to ALL past branches :) |
And I will delete the old branches after testing :). We want to have quick label selection. |
Ah.... We will need to get approval from INFRA
|
Created a JIRA issue https://issues.apache.org/jira/browse/INFRA-26262 |
oh i see :) |
nice thank you :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late to the party but this looks good! A mere idea transformed into something working looks fine :)
Hmm. it seems that we might have some hard time (and I kind of agree with it eventually) about using pull_request_target for that one - INFRA (Rightfully) is worried about security of those, so we should likely look for alternative - where we could either user |
I will revert it for now |
This reverts commit 9ee9e52.
Yes agree , we can look some alternatives, I have posted another alternative on slack thread which gives ability to use workflow_dispatch, and I feel we can automate this some way. But not entirely sure thats the right path :) please suggest |
https://apache-airflow.slack.com/archives/C0808SJPNGM/p1731388388011519 |
This reverts commit 9ee9e52.
* include pr number in job name * update version number and branch name structure
This reverts commit 9ee9e52.
Adding backport action workflow , to automate PR's that require backport to other branches.
This backports the merged commit to the specified backport branch lable ex:
backport-to-v2-10-test
, then it usesv2-10-test
as the target branch to to backportBackport action repo: https://github.com/sorenlouv/backport-github-action/
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.