review comment

apache · Oct 8, 2024 · 6f9d469 · 6f9d469
1 parent e16e873
commit 6f9d469
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/apisix/plugins/ai-rag.lua b/apisix/plugins/ai-rag.lua
@@ -39,6 +39,7 @@ local schema = {
             -- ensure only one provider can be configured while implementing support for
             -- other providers
             required = { "azure_openai" },
+            maxProperties = 1,
         },
         vector_search_provider = {
             type = "object",
@@ -47,7 +48,8 @@ local schema = {
             },
             -- ensure only one provider can be configured while implementing support for
             -- other providers
-            required = { "azure_ai_search" }
+            required = { "azure_ai_search" },
+            maxProperties = 1
         },
     },
     required = { "embeddings_provider", "vector_search_provider" }

diff --git a/apisix/plugins/ai-rag/embeddings/azure_openai.lua b/apisix/plugins/ai-rag/embeddings/azure_openai.lua
@@ -16,6 +16,7 @@
 --
 local core = require("apisix.core")
 local HTTP_INTERNAL_SERVER_ERROR = ngx.HTTP_INTERNAL_SERVER_ERROR
+local HTTP_OK = ngx.HTTP_OK
 local type = type
 
 local _M = {}
@@ -52,7 +53,7 @@ function _M.get_embeddings(conf, body, httpc)
         return nil, HTTP_INTERNAL_SERVER_ERROR, err
     end
 
-    if res.status ~= 200 then
+    if res.status ~= HTTP_OK then
         return nil, res.status, res.body
     end
 

diff --git a/apisix/plugins/ai-rag/vector-search/azure_ai_search.lua b/apisix/plugins/ai-rag/vector-search/azure_ai_search.lua
@@ -16,6 +16,7 @@
 --
 local core = require("apisix.core")
 local HTTP_INTERNAL_SERVER_ERROR = ngx.HTTP_INTERNAL_SERVER_ERROR
+local HTTP_OK = ngx.HTTP_OK
 
 local _M = {}
 
@@ -61,7 +62,7 @@ function _M.search(conf, search_body, httpc)
         return nil, HTTP_INTERNAL_SERVER_ERROR, err
     end
 
-    if res.status ~= 200 then
+    if res.status ~= HTTP_OK then
         return nil, res.status, res.body
     end