Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve opentelemetry plugin docs #11900

Merged
merged 8 commits into from
Jan 17, 2025
Merged

docs: improve opentelemetry plugin docs #11900

merged 8 commits into from
Jan 17, 2025
+285 −240

Conversation

Yilialinn
Copy link
Contributor

@Yilialinn Yilialinn commented Jan 8, 2025 •
edited
Loading

Description

Improve opentelemetry plugin docs and add Chinese doc.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. doc Documentation things labels Jan 8, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 8, 2025
kayx23
kayx23 reviewed Jan 14, 2025
View reviewed changes
docs/en/latest/plugins/opentelemetry.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/opentelemetry.md Outdated Show resolved Hide resolved
docs/en/latest/plugins/opentelemetry.md Outdated Show resolved Hide resolved
Yilialinn and others added 3 commits January 14, 2025 17:22
@Yilialinn @kayx23
Update docs/en/latest/plugins/opentelemetry.md
b8b31b1 
Co-authored-by: Traky Deng <trakydeng@gmail.com>
@Yilialinn @kayx23
Update docs/en/latest/plugins/opentelemetry.md
965df83 
Co-authored-by: Traky Deng <trakydeng@gmail.com>
@Yilialinn
fix comments & lint
0885e56
@kayx23
Copy link
Member

kayx23 commented Jan 15, 2025

English doc LGTM. Please add zh doc.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jan 16, 2025
@bzp2010 bzp2010 merged commit 6244b74 into apache:master Jan 17, 2025
7 checks passed
@Yilialinn Yilialinn deleted the patch-3 branch January 17, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayx23 kayx23 kayx23 approved these changes

@moonming moonming moonming approved these changes

@bzp2010 bzp2010 bzp2010 approved these changes

Assignees
No one assigned
Labels
doc Documentation things size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yilialinn @kayx23 @bzp2010 @moonming