Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add consul_kv to the README.md file #8865

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

Amishakumari544
Copy link
Contributor

@Amishakumari544 Amishakumari544 commented Feb 15, 2023

Description

Fixes #8533

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

cc- @spacewander @bzp2010 @moonming @navendu-pottekkat

@Amishakumari544 Amishakumari544 changed the title Add consul kv to README.md docs: add consul kv to README.md Feb 15, 2023
@Amishakumari544 Amishakumari544 changed the title docs: add consul kv to README.md docs: add consul_kv to the README.md file Feb 15, 2023
Copy link
Member

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the unrelated changes?

Signed-off-by: Amishakumari544 <amishakumari544@gmail.com>
Signed-off-by: Amishakumari544 <amishakumari544@gmail.com>
@Amishakumari544
Copy link
Contributor Author

Amishakumari544 commented Feb 16, 2023

Could you remove the unrelated changes?

apologies , done now. @navendu-pottekkat

Copy link
Member

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this needs to be added. Maybe others can comment.

@github-actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 24, 2023
@moonming moonming removed the stale label Oct 9, 2023
@moonming
Copy link
Member

moonming commented Oct 9, 2023

@Amishakumari544 it will be great if you can help to resolve conflicts, thanks

moonming
moonming previously approved these changes Oct 18, 2023
@Fabriceli
Copy link
Contributor

@Amishakumari544 Could you fix the CI error?

@moonming
Copy link
Member

@kayx23 please take a look at this PR, thx

README.md Outdated Show resolved Hide resolved
@moonming moonming merged commit 804c4ee into apache:master Nov 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

docs: add consul link to README.md file
5 participants