docs: update info about plugin execution order and phases #9999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please make the ci pass |
monkeyDluffy6017
added
the
wait for update
monkeyDluffy6017
added
discuss
and removed
wait for update
|
@kayx23 please help to check this |
kayx23
requested changes
Aug 23, 2023
kayx23
reviewed
Aug 24, 2023
Co-authored-by: Traky Deng <trakydeng@gmail.com>
monkeyDluffy6017
added
wait for update
|
@monkeyDluffy6017 I've reviewed this and my comment is as follows: #10031 (comment) Notably, I don't think the global plugin running ONLY on Let's continue this convo in the issue above. |
|
@monkeyDluffy6017, should we support plugins that run in other phases except |
|
@shreemaan-abhishek I will close this pr since we are going to support global rules run in other phases |
|
This PR has other helpful doc changes other than the global plugin running ONLY on before_proxy(), so I'm reopening. |
kayx23
reviewed
Sep 27, 2023
kayx23
reviewed
Sep 27, 2023
Co-authored-by: Traky Deng <trakydeng@gmail.com>
kayx23
removed
the
wait for update
kayx23
changed the title
kayx23
approved these changes
Oct 9, 2023
monkeyDluffy6017
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the current situation of documentation, it's very likely that users might end up not having any context aboutGlobal ruleswhen considering the plugin execution precedence.Update info about plugin execution order and phases.
Checklist