Skip to content

Commit

Permalink
remove unrelated changes
Browse files Browse the repository at this point in the history
  • Loading branch information
XiangpengHao committed Jan 8, 2025
1 parent e4d9eb7 commit 21e015b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions parquet/src/arrow/array_reader/byte_view_array.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,7 @@ impl ColumnValueDecoder for ByteViewArrayColumnValueDecoder {
self.validate_utf8,
);
decoder.read(&mut buffer, usize::MAX)?;

self.dict = Some(buffer);

Ok(())
}

Expand Down Expand Up @@ -309,9 +307,6 @@ impl ByteViewArrayDecoderPlain {
num_values: Option<usize>,
validate_utf8: bool,
) -> Self {
// Here we convert `bytes::Bytes` into `arrow_buffer::Bytes`, which is zero copy
// Then we convert `arrow_buffer::Bytes` into `arrow_buffer:Buffer`, which is also zero copy
let buf = arrow_buffer::Buffer::from_bytes(buf.clone().into());
Self {
buf: Buffer::from(buf),
offset: 0,
Expand Down
2 changes: 1 addition & 1 deletion parquet/src/arrow/arrow_reader/filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ where
/// [`RowSelection`]: crate::arrow::arrow_reader::RowSelection
pub struct RowFilter {
/// A list of [`ArrowPredicate`]
pub predicates: Vec<Box<dyn ArrowPredicate>>,
pub(crate) predicates: Vec<Box<dyn ArrowPredicate>>,
}

impl RowFilter {
Expand Down

0 comments on commit 21e015b

Please sign in to comment.