Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #6792

Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 25, 2024

Which issue does this PR close?

None

Rationale for this change

Removing the deps speeds the compilation up

What changes are included in this PR?

cargo.toml pruning

Are there any user-facing changes?

no

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels Nov 25, 2024
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could enable a lint to test for this?

@alamb
Copy link
Contributor

alamb commented Nov 25, 2024

Perhaps we could enable a lint to test for this?

Filed #6796 to track

@alamb alamb merged commit ce54e52 into apache:main Nov 25, 2024
27 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 25, 2024

Thanks @findepi and @mbrobbel and @tustvold

@findepi findepi deleted the findepi/remove-unused-dependencies-72d825 branch November 25, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants