fix(flightsql): remove Any encoding of DoPutUpdateResult #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
tustvold
approved these changes
Dec 3, 2024
|
FWIW if you have time #6546 would be very valuable |
|
@tustvold I'll see if I can't find some time later this week to look into those tests. |
davisp
added a commit
to davisp/arrow-flightsql-rs
that referenced
this pull request
Dec 3, 2024
This repo exists solely so that it can be patched into other projects. Once [this PR](apache/arrow-rs#6825) is on crates.io this repository will get blown up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6545
Rationale for this change
This is a nearly identical issue to #5731 which was fixed via #5817. I've just taken the logic in #5817 and applied it to the
DoPutUpdateResultmessage as well.What changes are included in this PR?
Remove the Any encoding of
DoPutUpdateResult.Are there any user-facing changes?
Users of languages that are not Rust will get correct row counts back from Rust FlightSQL servers.