Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to twox-hash 2.0 #6583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shepmaster
Copy link
Contributor

@shepmaster shepmaster commented Oct 18, 2024

Thanks for using my crate!

Note that version 2.0 increases the MSRV to Rust 1.81. I understand if you don't want to upgrade right away, but hopefully this PR will be useful when you do.

I'm opening these PRs for the top users of twox-hash and have no current plans to become a consistent contributor to this specific repository; please feel free to rewrite the commit as appropriate for your project's requirements.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Oct 18, 2024
@alamb
Copy link
Contributor

alamb commented Oct 21, 2024

Thank you @shepmaster

@Jefffrey
Copy link
Contributor

Jefffrey commented Jan 5, 2025

I don't think this repo currently has a defined MSRV strategy, relevant links:

There's time to decide before the next major release of 55.0.0 in Mar 2025 (reference) as this would be a breaking change in bumping the MSRV anyway. By then the latest Rust version should be 1.85.0.

A TODO item before considering this PR for that release would also be running benchmarks for parquet bloom filters. I tried doing this but found the results fluctuated a bit too much for consecutive runs of cargo bench -p parquet bloom (with and without changes); can try again later.

@Jefffrey Jefffrey added the next-major-release the PR has API changes and it waiting on the next major version label Jan 5, 2025
@alamb
Copy link
Contributor

alamb commented Jan 8, 2025

Update is here: apache/datafusion#14045

Sorry wrong ticket 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-major-release the PR has API changes and it waiting on the next major version parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants