Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose 'parquet::record::make_row' function call to users #6762

Closed
wants to merge 1 commit into from

Conversation

jonded94
Copy link
Contributor

Which issue does this PR close?

Closes #6761

Rationale for this change

parquet::record::make_row was not exposed to users, leaving them no option to create parquet::record::Row objects themselfes.

What changes are included in this PR?

parquet::record::make_row is exposed publicy.

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 20, 2024
@etseidl
Copy link
Contributor

etseidl commented Nov 20, 2024

If we want to allow creating Rows outside the module, would it be better to add a public new() to the Row API? (And maybe get rid of make_row?)

cc @alamb @tustvold

@jonded94
Copy link
Contributor Author

Implemented an alternative PR which does remove make_row entirely and creates a new method. #6763

Let me know whichever approach you prefer :) This unfortunately currently blocks a bit my work (I have some manual steps where I explicitly modify & create new Row instances and can't do that right now), so I'm happy to have quick progress here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parquet::record::make_row is not exposed to users, leaving no option to users to manually create Row objects
2 participants