Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove redundant bit_util::ceil #6766

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: remove redundant bit_util::ceil #6766

merged 1 commit into from
Nov 21, 2024

Conversation

miroim
Copy link
Contributor

@miroim miroim commented Nov 21, 2024

Which issue does this PR close?

Closes #6750.

Rationale for this change

BooleanBufferBuilder::new function takes length in bits already, no need for bit_util::ceil

What changes are included in this PR?

remove redundant bit_util::ceil

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 21, 2024
@Dandandan Dandandan merged commit 853626e into apache:master Nov 21, 2024
25 of 26 checks passed
@Dandandan
Copy link
Contributor

Thanks @miroim

@miroim miroim deleted the remove_bit_util branch November 22, 2024 01:04
@alamb alamb mentioned this pull request Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dandandan Dandandan Dandandan approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filter_bits under-allocates resulting boolean buffer
2 participants
@miroim @Dandandan