Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include license and notice files in published crates #6767

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ankane
Copy link
Contributor

@ankane ankane commented Nov 21, 2024

Which issue does this PR close?

None

Rationale for this change

This is nice for cargo vendor and other tools (microsoft/windows-rs#1587 (comment)).

What changes are included in this PR?

This symlinks LICENSE.txt and NOTICE.txt so they're included in the published crates.

Are there any user-facing changes?

N/A

@github-actions github-actions bot added parquet Changes to the parquet crate arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet-derive labels Nov 21, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ankane for this change!

@tustvold tustvold merged commit 0974cff into apache:master Nov 21, 2024
27 of 28 checks passed
@ankane
Copy link
Contributor Author

ankane commented Nov 21, 2024

Thanks @Xuanwo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate parquet-derive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants