[CALCITE-6665] Code Review

apache · Dec 19, 2024 · b85b5b4 · b85b5b4
1 parent 0f46436
commit b85b5b4
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/core/src/main/java/org/apache/calcite/tools/RelBuilder.java b/core/src/main/java/org/apache/calcite/tools/RelBuilder.java
@@ -2679,6 +2679,8 @@ private boolean alreadyUnique(List<AggCallPlus> aggCallList,
       List<RexNode> extraNodes) {
     final RelMetadataQuery mq = peek().getCluster().getMetadataQuery();
     if (aggCallList.isEmpty() && groupSet.isEmpty()) {
+      // We can't remove "GROUP BY ()" if there's a chance the rel could be
+      // empty.
       if (RelMdUtil.isRelDefinitelyEmpty(mq, peek())) {
         return false;
       }