[CALCITE-6690] Arrow adapter support DECIMAL with precision and scale #4092
Conversation
caicancai
changed the title
caicancai
force-pushed
the
6690-2
branch
4 times, most recently
from
81e9176 to
89d1317
Compare
|
|
||
| ArrowFieldType(Class<?> clazz) { | ||
| this.clazz = clazz; | ||
| private ArrowFieldType() { |
There was a problem hiding this comment.
this looks like a factory, so the name of the class is probably not appropriate.
There was a problem hiding this comment.
Do you need me to optimize it?
There was a problem hiding this comment.
you don't need to optimize anything, just use a name that is appropriate. This is not a type, it is a class which creates types, so it is a factory.
| @@ -237,35 +239,38 @@ public void writeArrowDataType(File file) throws IOException { | |||
| vectorSchemaRoot.setRowCount(numRows); | |||
| for (Field field : vectorSchemaRoot.getSchema().getFields()) { | |||
| FieldVector vector = vectorSchemaRoot.getVector(field.getName()); | |||
| switch (vector.getMinorType()) { | |||
| case TINYINT: | |||
| switch (field.getName()) { | |||
There was a problem hiding this comment.
Sorry for taking so long to reply.
This is because I set two fields for decimal type, one with scale 2 and one with scale 3. Since there are two decimal types, it is no longer appropriate to distinguish based on data type.
I chose the field name to distinguish
There was a problem hiding this comment.
So, this is just test code. Can you change the file name to ArrowTestData?
There was a problem hiding this comment.
@mihaibudiu thanks, done
caicancai
force-pushed
the
6690-2
branch
3 times, most recently
from
ce2e5c5 to
7c22892
Compare
…brary in SqlOperatorTest
…ameter is Boolean, String, Date, Time and Timestamp types
… is too narrow Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
…y is affected by the order of hosts Update ElasticsearchSchemaFactory.java Add unit test add unit test Modify code implementation and unit test Reformat code Test unit is compatible with Java8 Reformat code Reformat code Reformat code Add jira link
…s, maps without regard to element types Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
For certain query patterns RelMdUniqueKeys handler generates an exponentially large number of unique keys that results into crashes and OOM errors. The limit guards against the combinatorial explosion that may appear for such use-cases and provides the users of a way to tune further the upper bound if needed. Close apache#4089
…hich are arguments of unused aggregate functions
Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
|
I'm sorry I messed up the branches, I'll make a new PR |
|
No description provided.