[CALCITE-6742] StandardConvertletTable.convertCall loses casts from ROW comparisons #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
commented
Dec 21, 2024
| @@ -563,9 +563,15 @@ private Expression getConvertExpression( | |||
| case TINYINT: | |||
| case SMALLINT: { | |||
| if (SqlTypeName.NUMERIC_TYPES.contains(sourceType.getSqlTypeName())) { | |||
| Type javaClass = typeFactory.getJavaClass(targetType); | |||
There was a problem hiding this comment.
This change is only indirectly related to this PR: without this change, the code generated for ROW casts crashes at runtime.
There was a problem hiding this comment.
Why does it crash? It feels a bit strange
mihaibudiu
force-pushed
the
issue6742
branch
2 times, most recently
from
64104e8 to
c71763a
Compare
|
This PR fixes a real bug and should not be too hard to review. |
caicancai
approved these changes
Dec 24, 2024
ILuffZhe
reviewed
Dec 24, 2024
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
Outdated
Show resolved
Hide resolved
ILuffZhe
reviewed
Dec 24, 2024
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
Show resolved
Hide resolved
…OW comparisons Signed-off-by: Mihai Budiu <mbudiu@feldera.com>
mihaibudiu
force-pushed
the
issue6742
branch
from
c71763a to
3fd98b9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.