-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingress Trait to support an array on the path #5981
Comments
Thanks for the feature request. Are you planning to work on this by any chance? |
@squakez - I would very much like to try -- I'll take a walk through the developer's guide and see if I can work through how to implement the changes. |
Good progress so far, documentation has been excellent. I should be able to get a PR submitted in the coming days. |
Excellent. Just let us know if you have any doubt or you need any help! |
TL;DR - I think this is bubbling up into a bigger issue. @squakez I have a working build (Draft PR #5996) , allowing a string array on the ingress.path, however, I have some doubts...
Best visual example of the hierarchy (from https://v1-30.docs.kubernetes.io/docs/concepts/services-networking/ingress/#hostname-wildcards): apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: ingress-wildcard-host
spec:
rules:
- host: "foo.bar.com"
http:
paths:
- pathType: Prefix
path: "/bar"
backend:
service:
name: service1
port:
number: 80
- host: "*.foo.com"
http:
paths:
- pathType: Prefix
path: "/foo"
backend:
service:
name: service2
port:
number: 80 Please let me know your thoughts. |
First of all thanks for the effort to put on a draft @cfitzw, really appreciated. About the specific problems you're mentioning:
I am not entirely sure what exactly you need to support, but I think we can separate this issue to work both on 1 and, if that makes sense, on 2, providing a different parameter for each feature we want. |
@squakez -- thank you for the feedback. I've implemented number 1 and committed to the PR. In regards to number 2, this is not a desired need at-the-moment, so let's focus on adding support for number 1 and this can become a new issue/PR at a later point-in-time. |
Requirement
Would like to set multiple paths and/or aliases for an integration.
Problem
Currently unable to utilize the ingress trait on an integration to set multiple paths for the ingress to consume.
It appears this is possible/supported via kubernetes documentation:
https://kubernetes.io/docs/concepts/services-networking/ingress/#examples
Proposal
Allow and array on ingress.path ([]string):
https://camel.apache.org/camel-k/2.5.x/apis/camel-k.html#_camel_apache_org_v1_trait_IngressTrait
Open questions
No response
The text was updated successfully, but these errors were encountered: