Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trait): let Camel runtime manages Kamelets #4812

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Oct 10, 2023

With this PR we get rid off the very first Kamelets runtime execution which translated the Kamelets into a route templates. We let now the Camel runtime to use the Kamelets as they are expected in the framework.

  • Add a configmap as a bundle for all kamelets used by the Integration
  • Mount the bundle in /etc/camel/kamelets
  • Let the runtime use the Kamelets instead of trasforming into RouteTemplates
  • Let the operator use the Kamelet template for capability parsing

Supersedes #4797
Closes #4618

Release Note

feat(trait): let Camel runtime manages Kamelets

@squakez
Copy link
Contributor Author

squakez commented Oct 10, 2023

@christophd this PR address the point you raised about sources parsing. It should be solved now. Consider that the default properties are no longer required as they are managed by the runtime.

@squakez squakez force-pushed the feat/4618_capabilities branch from 71ff66d to 2b5e3f6 Compare October 10, 2023 10:03
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.4% --> 33.5% (Coverage difference: +.1%)

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.4% --> 33.5% (Coverage difference: +.1%)

pkg/trait/camel.go Show resolved Hide resolved
@github-actions
Copy link
Contributor

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@github-actions
Copy link
Contributor

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@squakez squakez force-pushed the feat/4618_capabilities branch from a6449e6 to f8cc4d8 Compare October 13, 2023 13:25
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.4% --> 33.6% (Coverage difference: +.2%)

@squakez squakez force-pushed the feat/4618_capabilities branch 2 times, most recently from 269cc90 to 47747da Compare October 13, 2023 14:02
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.4% --> 33.6% (Coverage difference: +.2%)

* Add a configmap as a bundle for all kamelets used by the Integration
* Mount the bundle in /etc/camel/kamelets
* Let the runtime use the Kamelets instead of trasforming into RouteTemplates
* Let the operator use the Kamelet template for capability parsing

Closes apache#4618
To maintain backward compatibility
Configmap limit is 1 MB. We partition into more configmaps if the bundle exceed such limit.
@squakez squakez force-pushed the feat/4618_capabilities branch from 47747da to 0260d64 Compare October 16, 2023 07:53
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 33.4% --> 33.5% (Coverage difference: +.1%)

@squakez
Copy link
Contributor Author

squakez commented Oct 16, 2023

Failure does not seem related.

@squakez squakez merged commit 167d6af into apache:main Oct 16, 2023
15 of 16 checks passed
@squakez squakez deleted the feat/4618_capabilities branch October 16, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants