Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix#5280): Basic integration fails on ARM64 #5286

Closed
wants to merge 1 commit into from

Conversation

tdiesler
Copy link
Contributor

Release Note

NONE

Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ⚠️ - Coverage changed: 33.6% --> 33.5% (Coverage difference: -.1%)

@christophd
Copy link
Contributor

The logic here is different compared to that on main branch. Do we really have to backport a different logic to 2.2.x?

I am reffering to the func GetControllerArchitecture which I believe is not in main branch

@tdiesler
Copy link
Contributor Author

It depends on the scope of fix you'd like. IMHO, what we have in main is not mature enough to remain as is let alone ready to be backported to 2.2.x. In 2.2.x. there is a documented way on how to get an integration running on arm64, but it doesn't work (at least not on MacOS). It may work on Raspi4, but I haven't tried that. Did this ever work for you on your Mac?

@christophd
Copy link
Contributor

yes, the documented way did work for me IIRC

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release 2.3 is actually on vote. This one won't probably be ever released, so, not sure if it makes sense to keep it.

@tdiesler tdiesler closed this Apr 16, 2024
@tdiesler tdiesler deleted the ghi5280 branch April 23, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants