Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAVA-3065: PreparedStatementIT#should_fail_fast_if_id_changes_on_repr… #1662

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

hhughes
Copy link
Contributor

@hhughes hhughes commented Jun 26, 2023

…epare fails with recent C*/DSE versions

PreparedStatementIT.java

  • add multiple backend requirements to should_fail_fast_if_id_changes_on_reprepare covering versions impacted by CASSANDRA-15252
  • add handle_id_changes_on_reprepare to test CASSANDRA-15252 for versions which include the fix

BackendRequirement.java

  • new repeatable annotation for specifying multiple ranges of backend requirements for tests

VersionRequirementTest.java

  • tests for multiple ranges of backend requirements

refactor BaseCcmRule.java annotation logic and move to VersionRequirements.java remove duplicated annotation code from CcmPaxExam.java and EmbeddedAdsRule

…epare fails with recent C*/DSE versions

PreparedStatementIT.java
- add multiple backend requirements to should_fail_fast_if_id_changes_on_reprepare covering versions impacted by CASSANDRA-15252
- add handle_id_changes_on_reprepare to test CASSANDRA-15252 for versions which include the fix

BackendRequirement.java
- new repeatable annotation for specifying multiple ranges of backend requirements for tests

VersionRequirementTest.java
- tests for multiple ranges of backend requirements

refactor BaseCcmRule.java annotation logic and move to VersionRequirements.java
remove duplicated annotation code from CcmPaxExam.java and EmbeddedAdsRule
@hhughes
Copy link
Contributor Author

hhughes commented Jun 26, 2023

Reopened from #1650

@absurdfarce absurdfarce self-requested a review June 27, 2023 15:25
Copy link
Contributor

@absurdfarce absurdfarce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this includes everything we discussed... I think this one is ready to go!

@hhughes hhughes merged commit 4af9f5a into 4.x Jun 27, 2023
2 of 3 checks passed
@hhughes hhughes deleted the JAVA-3065 branch June 27, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants