Skip to content

Commit

Permalink
fix: CDV.h wasn't bringing in Cordova.h consistently (#1482)
Browse files Browse the repository at this point in the history
The fact that there's a circular dependency between the headers isn't
actually a problem in Objective-C because it uses `#import` rather than
`#include` and the compiler ensures each header is only included once.

Somehow that was also causing it to only evaluate the header once and
not differentiate imports where the macro was defined vs not defined.
  • Loading branch information
dpogue authored Aug 28, 2024
1 parent 458f5f3 commit 4a4294c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CordovaLib/include/Cordova/CDV.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@

#ifndef __CORDOVA_SILENCE_HEADER_DEPRECATIONS
#warning Import <Cordova/Cordova.h> rather than <Cordova/CDV.h>
#import <Cordova/Cordova.h>
#endif

#import <Cordova/Cordova.h>

0 comments on commit 4a4294c

Please sign in to comment.