fix: CDV.h wasn't bringing in Cordova.h consistently #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that there's a circular dependency between the headers isn't actually a problem in Objective-C because it uses `#import` rather than `#include` and the compiler ensures each header is only included once. Somehow that was also causing it to only evaluate the header once and not differentiate imports where the macro was defined vs not defined.
erisu
approved these changes
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1482 +/- ##
=======================================
Coverage 80.22% 80.22%
=======================================
Files 16 16
Lines 1871 1871
=======================================
Hits 1501 1501
Misses 370 370 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Plugins that included only
<Cordova/CDV.h>were seeing issues around extendingCDVPlugin.Description
Make
CDV.hconsistently importCordova.hto define the full module.The fact that there's a circular dependency between the headers isn't actually a problem in Objective-C because it uses
#importrather than#includeand the compiler ensures each header is only included once.Somehow that was also causing it to only evaluate the header once and not differentiate imports where the macro was defined vs not defined.
Testing
Compiled a test app whose plugins used
#import <Cordova/CDV.h>and were broken before this change.Checklist